Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upBetter error when div for embedding is undefined #634
Comments
added a commit
to noahzgordon/core
that referenced
this issue
Jun 7, 2016
added a commit
to noahzgordon/core
that referenced
this issue
Jun 7, 2016
added a commit
to noahzgordon/core
that referenced
this issue
Jun 7, 2016
noahzgordon
referenced this issue
Jun 7, 2016
Closed
Resolves #634; Raise and embed informative error message when rootDom… #640
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
noahzgordon
commented
Jun 7, 2016
•
edited
Edited 1 time
-
noahzgordon
edited Jun 7, 2016 (most recent)
edited
Edited 1 time
-
Jun 7, 2016 (most recent)
|
This seems like a clear win so I went ahead and made a PR. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
Mar 25, 2017
Member
No longer lives in core. It's in virtual-dom. Not sure if it's still an issue. If so, issue on the correct repo with SSCCE is good, PR is not useful.
|
No longer lives in core. It's in virtual-dom. Not sure if it's still an issue. If so, issue on the correct repo with SSCCE is good, PR is not useful. |
evancz
closed this
Mar 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hamiltop commentedMay 30, 2016
Right now it complains that it can't call
appendChildonundefined. Which makes sense, but if the intent is to treat Elm as a black box in production, then perhaps a check on the element existing and giving a clearer error would be helpful.