New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler generates invalid Javascript when repository name contains period. #642

Closed
dam5s opened this Issue Jun 9, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@dam5s

dam5s commented Jun 9, 2016

I compiled an elm application with the following elm-package.json:

{
    "version": "1.0.0",
    "repository": "https://github.com/dam5s/somanyfeeds.boot.git",
    "summary": "SoManyFeeds - Feed Aggregator",
    "license": "MIT",
    "source-directories": [
        "."
    ],
    "exposed-modules": [],
    "dependencies": {
        "elm-lang/core": "4.0.1 <= v < 5.0.0",
        "elm-lang/html": "1.0.0 <= v < 2.0.0",
        "evancz/elm-http": "3.0.1 <= v < 4.0.0",
        "evancz/elm-markdown": "3.0.0 <= v < 4.0.0"
    },
    "elm-version": "0.17.0 <= v < 0.18.0"
}

Repository name containing a period, generated variable names in javascript are invalid as they contain the period, which is invalid syntax.

@dam5s dam5s changed the title from Compiler generates invalid JSON when repository name contains period. to Compiler generates invalid Javascript when repository name contains period. Jun 9, 2016

@dam5s

This comment has been minimized.

Show comment
Hide comment
@dam5s

dam5s Jun 9, 2016

Wrong repo, and duplicate.

dam5s commented Jun 9, 2016

Wrong repo, and duplicate.

@dam5s dam5s closed this Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment