Date.month crash with dates in the distant future

[MrMovl]

If you manage to get an invalid date like Date.fromTime 10000000000000000, everything works until you try something like notADate |> Date.month |> toString |> Html.text. Then you get the runtime Error Uncaught TypeError: Cannot read property 'substring' of undefined It's the same for Date.dayOfWeek.

This seems unlikely, but you can reach that pretty quick when extrapolating Dates. Not sure if this can be fixed with the Date.month function. Maybe the problem could be solved if Date.fromTime would behave like Date.fromString and yield a Result or a Maybe.

Can be reproduced with the following on http://elm-lang.org/examples/hello-html

import Html
import Date

main =
let
notAMonth = Date.fromTime 10000000000000000 |> Date.month
in
notAMonth |> toString |> Html.text

[process-bot]

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

[process-bot]

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

[kuzux]

Just managed to reproduce the crash using Date.fromTime 10000000000000000 |> Date.month in repl

edit: Looking more into it, it seems to be caused by V8 JS engine returning a NaN citing invalid range error in new Date(). When we try to do anything with it, it just crashes. Adding an isNaN check on Date.fromTime should suffice.

[kuzux]

Just managed to reproduce the crash using Date.fromTime 10000000000000000 |> Date.month in repl

edit: Looking more into it, it seems to be caused by V8 JS engine returning a NaN citing invalid range error in new Date(). When we try to do anything with it, it just crashes. Adding an isNaN check on Date.fromTime should suffice.

[lukewestby]

Tracking in #816

[lukewestby]

Tracking in #816