Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDate.fromString calls strongly discouraged Javascript code #701
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
process-bot
Aug 27, 2016
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Aug 27, 2016
|
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
mariosangiorgio
referenced this issue
Aug 27, 2016
Closed
Date.fromString should not rely on new Date(...) #632
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
This is a duplicate of #632, follow along there. |
evancz
closed this
Aug 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mariosangiorgio commentedAug 27, 2016
I am working on some code that uses dates. When I looked at the documentation of
Date.fromStringI didn't find any indication about the format used so I had a look at the source code.I figured out it used the native Javascript Date. Reading the documentation on Mozilla's website I found this worrying note:
Has anyone looked into what these inconsistencies are?
I think we should do one of the following things:
What do you think?