Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uptoString #723
Comments
evancz
added
the
meta
label
Sep 22, 2016
elm
locked and limited conversation to collaborators
Sep 22, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
May 22, 2018
Member
#472 about parens should be fixed by elm-lang@b6b85af
The ctor thing should be solved by switching to $ for that name.
The JSON ones should be solved by the _Json_wrap and _Json_unwrap pattern, allowing me to show <internals> for all of those values.
I don't know if there is a fix for #812 at this time, but I'll wait til someone reopens something on it.
|
#472 about parens should be fixed by elm-lang@b6b85af The The JSON ones should be solved by the I don't know if there is a fix for #812 at this time, but I'll wait til someone reopens something on it. |
evancz commentedSep 22, 2016
•
edited by rtfeldman
Edited 1 time
-
rtfeldman
edited Jan 15, 2017 (most recent)
Easy Problems
Bad Input
ctorfield.Json.Valuewith cyclical referencesJson.Valuewith cyclical references (no http://sscce.org)The root problem here is that
toStringshould return something like<js>when given aJson.Valueof any kind. This can arise in a few situations.Possible solution: reintroduce
_field to all records. This way it is clear when something is a union type or record or JSON value. You can still cheat, but it will be more rare. This has a cost in the size of all record allocations.