/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting between Char and KeyCode: invalid 'in' operand y #73

Closed
sonnym opened this Issue Dec 30, 2014 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sonnym @Apanatshka
@sonnym

sonnym commented Dec 30, 2014

I found an interesting issue when converting between Chars and KeyCodes. Most of the credit goes to @Apanatshka for actually isolating the problem!

Example: http://share-elm.com/sprout/54a2d81de4b05f9c59b24a15
Original discussion that led to the discovery: https://groups.google.com/forum/#!topic/elm-discuss/VVKkA0TvFUE
@Apanatshka

This comment has been minimized.

Show comment
Hide comment
@Apanatshka

Apanatshka Dec 30, 2014

Most relevant part of the original discussion:

[...] it's an inconsistency somewhere between Native.Utils.chr, Native.Utils.eq and Native.Char.fromCode. I suspect it's just a forgotten call to Native.Utils.chr in Native.Char.fromCode.

Apanatshka commented Dec 30, 2014

Most relevant part of the original discussion:

[...] it's an inconsistency somewhere between Native.Utils.chr, Native.Utils.eq and Native.Char.fromCode. I suspect it's just a forgotten call to Native.Utils.chr in Native.Char.fromCode.

jonathanhefner added a commit to jonathanhefner/elm-core that referenced this issue Feb 2, 2015

@jonathanhefner
Add necessary String->Char conversion (fix #73)
392254e

@jonathanhefner jonathanhefner referenced this issue Feb 2, 2015

Merged

Add missing String->Char conversion (fix #73) #155

@evancz evancz closed this in 9f675dc Feb 2, 2015

evancz pushed a commit that referenced this issue Feb 2, 2015

@process-bot
Merge pull request #155 from jonathanhefner/issue-73-fix-char-fromcode 
Add missing String->Char conversion (fix #73)
800d068

kasbah added a commit to kasbah/elm-core that referenced this issue Mar 10, 2015

@jonathanhefner @kasbah
Add missing String->Char conversion (fix #73) 
Conflicts:
	src/Native/Char.js
	tests/Test/Char.elm
77bab70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment