Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDocumentation mentions Text.fromString as if it were still in core, but it was actually moved to `evancz/elm-graphics` #813
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
process-bot
Jan 16, 2017
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jan 16, 2017
|
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
jvoigtlaender
added
the
docs
label
Jan 16, 2017
added a commit
that referenced
this issue
Mar 25, 2017
evancz
closed this
Mar 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jvoigtlaender commentedJan 16, 2017
In http://package.elm-lang.org/packages/elm-lang/core/5.0.0/Basics#toString we read:
That reads as if the user should know or be easily able to find what
Text.fromStringis while browsing thecoredocumentation. It would make sense ifText.fromStringwere part ofcore. It was in the past, but now lives elsewhere: http://package.elm-lang.org/packages/evancz/elm-graphics/1.0.1/Text#fromStringEither the documentation of
Basics.toStringshould be written without referencingText.fromString, or it should point out whereText.fromStringcan be found (outsidecore).