Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upKeyCode called "unicode" in Char documentation #82
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kasbah
Jan 7, 2015
Contributor
Sorry, I investigated myself and it is the same thing as it uses fromCharCode under the hood. Feel free to close unless you feel the documentation could use improvement.
|
Sorry, I investigated myself and it is the same thing as it uses fromCharCode under the hood. Feel free to close unless you feel the documentation could use improvement. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kasbah
Jan 23, 2015
Contributor
I am even more confused now as toCode 'g' returns 71 which is the same as toCode 'G' (uppercase) even though it seems to be using c.charCodeAt(0); under the hood. I don't see where it is being converted to uppercase and I don't think the docs are clear enough that this behaviour is to be expected.
|
I am even more confused now as |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Ah, I just found #50 through |
kasbah
closed this
Jan 23, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Seems like the docs could be changed. Can you do a PR? |
kasbah commentedJan 7, 2015
Or am I missing something?
https://github.com/elm-lang/core/blob/master/src/Char.elm#L85