New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyCode called "unicode" in Char documentation #82

Closed
kasbah opened this Issue Jan 7, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@kasbah
Contributor

kasbah commented Jan 7, 2015

@kasbah

This comment has been minimized.

Show comment
Hide comment
@kasbah

kasbah Jan 7, 2015

Contributor

Sorry, I investigated myself and it is the same thing as it uses fromCharCode under the hood. Feel free to close unless you feel the documentation could use improvement.

Contributor

kasbah commented Jan 7, 2015

Sorry, I investigated myself and it is the same thing as it uses fromCharCode under the hood. Feel free to close unless you feel the documentation could use improvement.

@kasbah

This comment has been minimized.

Show comment
Hide comment
@kasbah

kasbah Jan 23, 2015

Contributor

I am even more confused now as toCode 'g' returns 71 which is the same as toCode 'G' (uppercase) even though it seems to be using c.charCodeAt(0); under the hood. I don't see where it is being converted to uppercase and I don't think the docs are clear enough that this behaviour is to be expected.

Contributor

kasbah commented Jan 23, 2015

I am even more confused now as toCode 'g' returns 71 which is the same as toCode 'G' (uppercase) even though it seems to be using c.charCodeAt(0); under the hood. I don't see where it is being converted to uppercase and I don't think the docs are clear enough that this behaviour is to be expected.

@kasbah

This comment has been minimized.

Show comment
Hide comment
@kasbah

kasbah Jan 23, 2015

Contributor

Ah, I just found #50 through git blame.

Contributor

kasbah commented Jan 23, 2015

Ah, I just found #50 through git blame.

@kasbah kasbah closed this Jan 23, 2015

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 23, 2015

Member

Seems like the docs could be changed. Can you do a PR?

Member

evancz commented Jan 23, 2015

Seems like the docs could be changed. Can you do a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment