New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change from 5.0.0 to 5.1.1 causes compilation errors if aliasing List.Extra as List #821

Closed
joeandaverde opened this Issue Jan 24, 2017 · 7 comments

Comments

Projects
None yet
6 participants
@joeandaverde

joeandaverde commented Jan 24, 2017

import List.Extra as List

My elm-package.json has these dependencies:

"elm-community/list-extra": "4.0.0 <= v < 5.0.0",
"elm-lang/core": "5.0.0 <= v < 6.0.0",

Error is:

-- NAMING ERROR - ././src/REDACTED_FILE_NAME_HERE.elm

This usage of variable `List.singleton` is ambiguous.

REDACTED LINE OF CODE 

Maybe you want one of the following?

    List.Extra.singleton
    List.singleton

This failed because we imported a module aliased with the same name as a core module. I imagine others will break for a similar reason. This type of import seems to be used commonly in many examples.

I think the problem is that list-extra and core didn't both get a major version upgrade.

List-Extra did a major version change whereas core did a minor version change. This discrepancy caused elm-package to download one update and not the other.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Jan 24, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Jan 24, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@joeandaverde

This comment has been minimized.

Show comment
Hide comment
@joeandaverde

joeandaverde Jan 24, 2017

In order for us to proceed with a build I believe the best course of action would be to specify exact versions.

joeandaverde commented Jan 24, 2017

In order for us to proceed with a build I believe the best course of action would be to specify exact versions.

@stephenreddek

This comment has been minimized.

Show comment
Hide comment
@stephenreddek

stephenreddek Jan 24, 2017

@joeandaverde elm-lang/elm-package#259 seems to make this fix impossible. Requires a code change to recover.

stephenreddek commented Jan 24, 2017

@joeandaverde elm-lang/elm-package#259 seems to make this fix impossible. Requires a code change to recover.

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Jan 25, 2017

Contributor

Upgrading to list-extra 6.0.0 should resolve this issue.

Contributor

mgold commented Jan 25, 2017

Upgrading to list-extra 6.0.0 should resolve this issue.

@joeandaverde

This comment has been minimized.

Show comment
Hide comment
@joeandaverde

joeandaverde Jan 25, 2017

Wouldn't that mean all of my dependencies that depend on List.Extra would have to upgrade to the latest version also?

joeandaverde commented Jan 25, 2017

Wouldn't that mean all of my dependencies that depend on List.Extra would have to upgrade to the latest version also?

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Jan 25, 2017

Contributor

...yes. Crud.

Contributor

mgold commented Jan 25, 2017

...yes. Crud.

@lukewestby

This comment has been minimized.

Show comment
Hide comment
@lukewestby

lukewestby May 17, 2017

Member

@joeandaverde @mgold is this resolved?

Member

lukewestby commented May 17, 2017

@joeandaverde @mgold is this resolved?

@evancz evancz closed this Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment