Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMinor change from 5.0.0 to 5.1.1 causes compilation errors if aliasing List.Extra as List #821
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Jan 24, 2017
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jan 24, 2017
|
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
joeandaverde
Jan 24, 2017
In order for us to proceed with a build I believe the best course of action would be to specify exact versions.
joeandaverde
commented
Jan 24, 2017
|
In order for us to proceed with a build I believe the best course of action would be to specify exact versions. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
stephenreddek
Jan 24, 2017
@joeandaverde elm-lang/elm-package#259 seems to make this fix impossible. Requires a code change to recover.
stephenreddek
commented
Jan 24, 2017
|
@joeandaverde elm-lang/elm-package#259 seems to make this fix impossible. Requires a code change to recover. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Upgrading to list-extra 6.0.0 should resolve this issue. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
joeandaverde
Jan 25, 2017
Wouldn't that mean all of my dependencies that depend on List.Extra would have to upgrade to the latest version also?
joeandaverde
commented
Jan 25, 2017
|
Wouldn't that mean all of my dependencies that depend on List.Extra would have to upgrade to the latest version also? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
...yes. Crud. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@joeandaverde @mgold is this resolved? |
joeandaverde commentedJan 24, 2017
import List.Extra as ListMy
elm-package.jsonhas these dependencies:Error is:
This failed because we imported a module aliased with the same name as a core module. I imagine others will break for a similar reason. This type of import seems to be used commonly in many examples.
I think the problem is that list-extra and core didn't both get a major version upgrade.
List-Extra did a major version change whereas core did a minor version change. This discrepancy caused elm-package to download one update and not the other.