New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation for Date.fromString #833

Closed
jinjor opened this Issue Feb 3, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@jinjor
Contributor

jinjor commented Feb 3, 2017

The document for Date.fromString is just saying

Attempt to read a date from a string.

, but does not describe what kind of string is valid.
Giving some examples or saying it is just the same as new Date() may be more helpful.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Feb 3, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Feb 3, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jul 10, 2017

Member

It makes sense to either go with ISO 8601 and rename this to fromIso8601 or to do something more serious to solve this in a better way.

Member

evancz commented Jul 10, 2017

It makes sense to either go with ISO 8601 and rename this to fromIso8601 or to do something more serious to solve this in a better way.

@evancz evancz closed this Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment