New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing Char.KeyCode #837

Closed
jinjor opened this Issue Feb 8, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@jinjor
Contributor

jinjor commented Feb 8, 2017

I believe ASCII (char code) and key code are different things. It took me a while to find I can use fromCode to convert 120 to 'x' (120 is F9 in key code). Could the documentation cover more general usages (e.g. reading binaries)? Also, it lacks information for error cases.

Maybe there are other solutions:

  • Just call it "Int"
  • Move these features to elm-lang/keyboard
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Feb 8, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Feb 8, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Mar 25, 2017

Member

elm-lang@3a6dc88 also improves the docs a bunch so a lot of functions are clearer.

Member

evancz commented Mar 25, 2017

elm-lang@3a6dc88 also improves the docs a bunch so a lot of functions are clearer.

@evancz evancz closed this Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment