Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNo warning given when a port module has no ports #869
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
May 28, 2017
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
May 28, 2017
|
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Mar 7, 2018
Member
I think elm/compiler#1386 should be the canonical issue for this.
Thank you for the report! It is helpful to see independent sources come to the same conclusion!
|
I think elm/compiler#1386 should be the canonical issue for this. Thank you for the report! It is helpful to see independent sources come to the same conclusion! |
kevgathuku commentedMay 28, 2017
•
edited
Edited 1 time
-
kevgathuku
edited May 28, 2017 (most recent)
When a module is declared as a
port moduleand it has no ports, I expected a warning to be raised, but no indication of this is given from Elm.Given that Elm recommends that very few modules should have ports in them, this case should give some feedback to the user.
Elm version:
0.18.0