Possible boundary condition in Array.slice

[dterhorst]

Version

$ elm repl
---- elm-repl 0.18.0 -----------------------------------------------------------
 :help for help, :exit to exit, more at <https://github.com/elm-lang/elm-repl>
--------------------------------------------------------------------------------

Code

> import Array
> Array.repeat 32 0 |> Array.slice 0 33

Expected Result

Array.fromList [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]
    : Array.Array number

Actual Result

TypeError: Cannot read property 'height' of undefined

Note

Array.repeat 31 0 |> Array.slice 0 33 works.
Array.repeat 32 0 |> Array.slice 0 33 fails.
Array.repeat 33 0 |> Array.slice 0 33 works.

Array.repeat 33 0 |> Array.slice 0 34 fails.

Given Array.repeat length 0 |> Array.slice 0 limit,
the problem seems to occur any time 32 <= length < limit.

---

A similar problem occurs with Array.fromList:

> List.repeat 33 0 |> Array.fromList |> Array.slice 0 34
TypeError: Cannot read property 'height' of undefined

However, it only occurs when the length of the list
is 33 <= length < limit as opposed to 32,
so there is something slightly different about that case.

[process-bot]

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

[process-bot]

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

[Skinney]

This should be fixed in Elm 0.19

[Skinney]

This should be fixed in Elm 0.19

[dterhorst]

Thanks. 👍

[dterhorst]

Thanks. 👍