New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color is not comparable, can't make a Set of them #894

Closed
Keyamoon opened this Issue Aug 8, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Keyamoon

Keyamoon commented Aug 8, 2017

Since Color is not comparable, I couldn't make a Set of them. I ended up writing a pair of functions to convert Color to and from tuples.

Why did I want to make a Set of Colors in the first place? Because Set helps me avoid duplicates, and I'm using it to extract and keep all the colors found in user input.

I just opened this issue to point out a use case regarding elm/compiler#1008.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Aug 8, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Aug 8, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz evancz added the request label Mar 7, 2018

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Mar 7, 2018

Member

This seems like a request to make Color into a comparable type.

I think doing one-off changes like this feels like progress, but it does not address the root issue, and in one or five or ten years, it will be quite a bad path. So I am not planning to change this in isolation.

Member

evancz commented Mar 7, 2018

This seems like a request to make Color into a comparable type.

I think doing one-off changes like this feels like progress, but it does not address the root issue, and in one or five or ten years, it will be quite a bad path. So I am not planning to change this in isolation.

@evancz evancz closed this Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment