Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upColor is not comparable, can't make a Set of them #894
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Aug 8, 2017
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Aug 8, 2017
|
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
evancz
added
the
request
label
Mar 7, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Mar 7, 2018
Member
This seems like a request to make Color into a comparable type.
I think doing one-off changes like this feels like progress, but it does not address the root issue, and in one or five or ten years, it will be quite a bad path. So I am not planning to change this in isolation.
|
This seems like a request to make I think doing one-off changes like this feels like progress, but it does not address the root issue, and in one or five or ten years, it will be quite a bad path. So I am not planning to change this in isolation. |
Keyamoon commentedAug 8, 2017
•
edited
Edited 1 time
-
Keyamoon
edited Aug 8, 2017 (most recent)
Since
Coloris notcomparable, I couldn't make aSetof them. I ended up writing a pair of functions to convertColorto and from tuples.Why did I want to make a
SetofColors in the first place? BecauseSethelps me avoid duplicates, and I'm using it to extract and keep all the colors found in user input.I just opened this issue to point out a use case regarding elm/compiler#1008.