Time helper functions inSeconds, inMinutes etc. error

[Saulzar]

Time is an alias for Float which specifies time as a unit of milliseconds as far as I can tell. However, the helper functions inSeconds

inSeconds : Time -> Float
inSeconds t =  t / second

For exampleisSeconds 2 = 0.002 !! Where 2 seconds should be 2000 milliseconds

Instead of divding by second it should be multiplied.

inSeconds : Time -> Float
inSeconds t =  t * second

[process-bot]

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

[process-bot]

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

[zwilias]

The intended usage, which isn't terribly well documented, is that you can do something like this:

twoMinutes : Time
twoMinutes = 2 * Time.minute

inSeconds twoMinutes --> 120

The multiplication you propose as implementation for the inSeconds function is pretty much what you would use right now to convert a Float into Time.

Perhaps a second set of functions can be added like fromSeconds which turns a number of seconds into an equivalent Time representation, though.

[zwilias]

The intended usage, which isn't terribly well documented, is that you can do something like this:

twoMinutes : Time
twoMinutes = 2 * Time.minute

inSeconds twoMinutes --> 120

The multiplication you propose as implementation for the inSeconds function is pretty much what you would use right now to convert a Float into Time.

Perhaps a second set of functions can be added like fromSeconds which turns a number of seconds into an equivalent Time representation, though.

[Skinney]

I think a lot of this confusion can be cleared up by specifying that Time represents milliseconds, and filling out examples for all the functions in the namespace.

[Skinney]

I think a lot of this confusion can be cleared up by specifying that Time represents milliseconds, and filling out examples for all the functions in the namespace.

[Skinney]

But the entire Time api is about to change in 0.19 anyway, right? So maybe this is a moot issue.

[Skinney]

But the entire Time api is about to change in 0.19 anyway, right? So maybe this is a moot issue.

[mkwiatkowski]

The API will change, but the documentation problem may remain. Current code on the dev branch is a bit confusing as the new Posix type seems to hold seconds (https://github.com/elm-lang/core/blob/dev/src/Time.elm#L62), but other functions treat it as milliseconds (https://github.com/elm-lang/core/blob/dev/src/Time.elm#L82).

[mkwiatkowski]

The API will change, but the documentation problem may remain. Current code on the dev branch is a bit confusing as the new Posix type seems to hold seconds (https://github.com/elm-lang/core/blob/dev/src/Time.elm#L62), but other functions treat it as milliseconds (https://github.com/elm-lang/core/blob/dev/src/Time.elm#L82).

[evancz]

There is a PR about adding docs for these functions (#920) so I'll let that be the canonical one.

The documentation is gonna get updated for the new API. It's not the same, so the docs cannot stay the same.

[evancz]

There is a PR about adding docs for these functions (#920) so I'll let that be the canonical one.

The documentation is gonna get updated for the new API. It's not the same, so the docs cannot stay the same.