Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNon-printable characters aren't escaped #923
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
process-bot
Dec 2, 2017
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Dec 2, 2017
|
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
rhofour
commented
Dec 2, 2017
|
Woops, this was supposed to be for elm-test. Closing this. |
rhofour
closed this
Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rhofour commentedDec 2, 2017
Right now it's impossible to tell he difference between String.fromList [ '\1', '\2' ] and an empty string when used as an input to a fuzz test. This caused some confusion when I thought the input was an empty string.
I'm not sure what the right solution is here, but as-is this a bit of a problem.
Perhaps we could check if a string contains unprintable characters and display it as: String.fromList [...] instead of the usual way.
Alternatively, we could add an option to change how the "Given:" portion of fuzz tests is displayed. That way I could print my data in the way that's most helpful for me, but we could keep the default unchanged.