New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics.Input.hoverable causes runtime error #93

Closed
mgold opened this Issue Jan 13, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@mgold
Contributor

mgold commented Jan 13, 2015

Minimum example:

import Graphics.Element as E
import Graphics.Input as Input
import Signal as S

chan = S.channel False

main = E.spacer 100 200 |> Input.hoverable (S.send chan)

Produces:

Cannot read property 'make' of undefined

Open the developer console for more details.

It seems to error on var Text = Elm.Native.Text.make(localRuntime); because Elm.Native.Text is undefined. Seems like a dependency ordering issue.

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Jan 13, 2015

Contributor

Related to elm/compiler#864. Solved by adding import Text to the top of the elm source.

Contributor

mgold commented Jan 13, 2015

Related to elm/compiler#864. Solved by adding import Text to the top of the elm source.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 13, 2015

Member

Could you make a PR?

Member

evancz commented Jan 13, 2015

Could you make a PR?

mgold added a commit to mgold/core that referenced this issue Jan 14, 2015

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Jan 14, 2015

Contributor

headslap I was adding it to the client code but yes adding it to the library fixes it as well.

Contributor

mgold commented Jan 14, 2015

headslap I was adding it to the client code but yes adding it to the library fixes it as well.

@evancz evancz closed this in #96 Jan 14, 2015

kasbah added a commit to kasbah/elm-core that referenced this issue Jan 23, 2015

Add `import Text` to fix runtime error.
Fixes #93.

Conflicts:
	src/Graphics/Input.elm

kasbah added a commit to kasbah/elm-core that referenced this issue Jan 23, 2015

kasbah added a commit to kasbah/elm-core that referenced this issue Jan 23, 2015

kasbah added a commit to kasbah/elm-core that referenced this issue Feb 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment