New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badIndex in Native/Json.js defined twice #936

Closed
mzero opened this Issue Jan 12, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@mzero

mzero commented Jan 12, 2018

The function badIndex is defined twice in the file Native/Json.js:

line 166
line 176

The definitions are identical.
This isn't a problem for JavaScript, but causes Closure Compiler to barf:

JSC_BLOCK_SCOPED_DECL_MULTIPLY_DECLARED_ERROR: Duplicate let / const / class / function declaration in the same scope is not allowed. at line 6664 character 9
function badIndex(index, nestedProblems)
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Jan 12, 2018

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Jan 12, 2018

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@zwilias

This comment has been minimized.

Show comment
Hide comment
@zwilias

zwilias Jan 12, 2018

Member

This got fixed in the dev branch so will be included in the next release of elm-lang/core. Thanks for logging the issue!

Member

zwilias commented Jan 12, 2018

This got fixed in the dev branch so will be included in the next release of elm-lang/core. Thanks for logging the issue!

@zwilias zwilias closed this Jan 12, 2018

ravicious referenced this issue in ravicious/memories-timeline Jan 22, 2018

Replace Closure compiler with uglify-js
Closure compiler's SIMPLE_OPTIMIZATIONS don't work due to a problem with
Elm core: https://github.com/elm-lang/core/issues/936
@YetAnotherMinion

This comment has been minimized.

Show comment
Hide comment
@YetAnotherMinion

YetAnotherMinion Apr 28, 2018

It is cool that this bug has been fixed for Elm 0.19, but there are a lot of people still using Elm 0.18 because 0.19 has not been released yet! Is there a process for backporting the fix to the 5.1 version of this library (I will do all the work)? Looking at the git history, it does not look like release branches are being used, is there opposition to creating one from the 5.1.1 tag? I could then cherry pick the badIndex fix onto it, and a member could release a 5.1.2 bugfix for all Elm users in ~5 minutes.

YetAnotherMinion commented Apr 28, 2018

It is cool that this bug has been fixed for Elm 0.19, but there are a lot of people still using Elm 0.18 because 0.19 has not been released yet! Is there a process for backporting the fix to the 5.1 version of this library (I will do all the work)? Looking at the git history, it does not look like release branches are being used, is there opposition to creating one from the 5.1.1 tag? I could then cherry pick the badIndex fix onto it, and a member could release a 5.1.2 bugfix for all Elm users in ~5 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment