Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upbadIndex in Native/Json.js defined twice #936
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Jan 12, 2018
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jan 12, 2018
|
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zwilias
Jan 12, 2018
Member
This got fixed in the dev branch so will be included in the next release of elm-lang/core. Thanks for logging the issue!
|
This got fixed in the |
zwilias
closed this
Jan 12, 2018
referenced
this issue
in ravicious/memories-timeline
Jan 22, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
YetAnotherMinion
Apr 28, 2018
It is cool that this bug has been fixed for Elm 0.19, but there are a lot of people still using Elm 0.18 because 0.19 has not been released yet! Is there a process for backporting the fix to the 5.1 version of this library (I will do all the work)? Looking at the git history, it does not look like release branches are being used, is there opposition to creating one from the 5.1.1 tag? I could then cherry pick the badIndex fix onto it, and a member could release a 5.1.2 bugfix for all Elm users in ~5 minutes.
YetAnotherMinion
commented
Apr 28, 2018
|
It is cool that this bug has been fixed for Elm 0.19, but there are a lot of people still using Elm 0.18 because 0.19 has not been released yet! Is there a process for backporting the fix to the 5.1 version of this library (I will do all the work)? Looking at the git history, it does not look like release branches are being used, is there opposition to creating one from the 5.1.1 tag? I could then cherry pick the badIndex fix onto it, and a member could release a 5.1.2 bugfix for all Elm users in ~5 minutes. |
mzero commentedJan 12, 2018
The function
badIndexis defined twice in the file Native/Json.js:line 166
line 176
The definitions are identical.
This isn't a problem for JavaScript, but causes Closure Compiler to barf: