Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upJson.Decode.lazy doc link to hint is broken #950
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Mar 13, 2018
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Mar 13, 2018
|
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
May 22, 2018
Member
Sorry for the inconvenience on that! The link should have been:
https://github.com/elm-lang/elm-compiler/blob/0.18.0/hints/recursive-alias.md
So that it could survive future code changes. I don't think there is a way to fix it retroactively, but we will be doing things in a different way in the next release such that this should not happen again!
|
Sorry for the inconvenience on that! The link should have been: https://github.com/elm-lang/elm-compiler/blob/0.18.0/hints/recursive-alias.md So that it could survive future code changes. I don't think there is a way to fix it retroactively, but we will be doing things in a different way in the next release such that this should not happen again! |
osteele commentedMar 13, 2018
Steps to reproduce:
lazy, under "Fancy Decoding"Expected: A documentation page
Actual: 404 error
Changing
https://github.com/elm-lang/elm-compiler/blob/master/hints/recursive-alias.mdtohttps://github.com/elm-lang/elm-compiler/blob/master/docs/hints/recursive-alias.mdinsrc/Json/Decode.elmfixes the issue.The reason I'm submitting this as an Issue instead of a PR fix is that
src/Json/Decode.elmdoesn't exist inelm-lang's branches (masteranddev). As a non-contributor, I don't know enough about the workflow to know how (or whether) this can be fixed.If it's useful, a git patch is attached.
0001-Fix-broken-link-in-Json.Decode.lazy-docs.patch.txt