New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added explicit export list to Char.elm #100

Merged
merged 1 commit into from Jan 16, 2015

Conversation

Projects
None yet
2 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Jan 15, 2015

meant to address part of elm/elm-lang.org#173

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jan 15, 2015

Contributor

When exporting a type alias, like KeyCode here, will the importing module "know" that KeyCode is Int, or will this be opaque from the outside?

Contributor

jvoigtlaender commented Jan 15, 2015

When exporting a type alias, like KeyCode here, will the importing module "know" that KeyCode is Int, or will this be opaque from the outside?

evancz pushed a commit that referenced this pull request Jan 16, 2015

Merge pull request #100 from jvoigtlaender/exports-Char
added explicit export list to Char.elm

@evancz evancz merged commit 73c4c15 into elm:master Jan 16, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 16, 2015

Member

As things stand, the outside module will know. I think this is the right way to go in the sense that you can do hiding with type KeyCode = KeyCode Int and we'll eventually do the same unboxing trick that OCaml and Haskell do (the newtype trick in Haskell)

Member

evancz commented Jan 16, 2015

As things stand, the outside module will know. I think this is the right way to go in the sense that you can do hiding with type KeyCode = KeyCode Int and we'll eventually do the same unboxing trick that OCaml and Haskell do (the newtype trick in Haskell)

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:exports-Char branch Jan 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment