Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCherry-pick for 1.1.1 attempt2 #134
Conversation
jonathanhefner
and others
added some commits
Jan 21, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Made some amendments after the CI build failed. |
pushed a commit
that referenced
this pull request
Feb 22, 2015
evancz
merged commit 2bfa6ab
into
elm:stable
Feb 22, 2015
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Feb 22, 2015
Member
Sorry for the delay, this looks good to me! I'll push it to the public repo soon.
|
Sorry for the delay, this looks good to me! I'll push it to the public repo soon. |
mgold
reviewed
Feb 22, 2015
| @@ -17,6 +17,7 @@ To learn about text fields, see the | ||
| import Signal | ||
| import Graphics.Element (Element) | ||
| import Native.Graphics.Input | ||
| import Text -- used internally |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mgold
Feb 22, 2015
Contributor
Uh-uh - this should be Native.Text (with no comment). It will still fix the bug but isn't quite as nice on the source code level.
mgold
Feb 22, 2015
Contributor
Uh-uh - this should be Native.Text (with no comment). It will still fix the bug but isn't quite as nice on the source code level.
TheSeamau5
referenced this pull request
Feb 22, 2015
Closed
toCode and fromCode should be inverse operations #174
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Feb 22, 2015
Member
Let me see if I understand exactly. We have a PR to stable that just has patch changes. It can be merged in and released whenever. Is that the idea?
Does this have any implications for merging in all of master at some later date? Otherwise, this sounds great to me, and I'm happy to do 1.1.2 to get the other fixes in there.
|
Let me see if I understand exactly. We have a PR to stable that just has patch changes. It can be merged in and released whenever. Is that the idea? Does this have any implications for merging in all of master at some later date? Otherwise, this sounds great to me, and I'm happy to do 1.1.2 to get the other fixes in there. |
kasbah commentedJan 23, 2015
Proposing this as an alternative to #133 as there were a lot less commits mentioning the word "fix" than I initially thought (got my git revision range wrong). So here they are cherry picked. Let's see how the CI likes it.
Happy to prune out any you don't like or add any as well, or go back to doing it more manually with #133.