Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upmore descriptive local function names in fpsWhen #136
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jwmerrill
Jan 24, 2015
Contributor
I think this is a good change. Nice thought.
On Fri, Jan 23, 2015 at 10:11 PM Janis Voigtländer notifications@github.com
wrote:
After a good night's sleep, thought of these more descriptive function
names, hopefully making clear to the reader of this function what the role
of the Boolean value used there is.@jwmerrill https://github.com/jwmerrill, what do you think of these
names?
You can view, comment on, or merge this pull request online at:
https://github.com/elm-lang/core/pull/136
Commit Summary
- more descriptive local function names in fpsWhen
File Changes
- M src/Native/Time.js
https://github.com/elm-lang/core/pull/136/files#diff-0 (7)Patch Links:
—
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/pull/136.
|
I think this is a good change. Nice thought.
|
jvoigtlaender
added some commits
Jan 24, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I like it too, thanks again! |
jvoigtlaender commentedJan 24, 2015
After a good night's sleep, thought of these more descriptive function names, hopefully making clear to the reader of this function what the role of the Boolean value used there is.
@jwmerrill, what do you think of these names?