New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more descriptive local function names in fpsWhen #136

Merged
merged 3 commits into from Jan 24, 2015

Conversation

Projects
None yet
3 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Jan 24, 2015

After a good night's sleep, thought of these more descriptive function names, hopefully making clear to the reader of this function what the role of the Boolean value used there is.

@jwmerrill, what do you think of these names?

@jwmerrill

This comment has been minimized.

Show comment
Hide comment
@jwmerrill

jwmerrill Jan 24, 2015

Contributor

I think this is a good change. Nice thought.
On Fri, Jan 23, 2015 at 10:11 PM Janis Voigtländer notifications@github.com
wrote:

After a good night's sleep, thought of these more descriptive function
names, hopefully making clear to the reader of this function what the role
of the Boolean value used there is.

@jwmerrill https://github.com/jwmerrill, what do you think of these

names?

You can view, comment on, or merge this pull request online at:

https://github.com/elm-lang/core/pull/136
Commit Summary

  • more descriptive local function names in fpsWhen

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/pull/136.

Contributor

jwmerrill commented Jan 24, 2015

I think this is a good change. Nice thought.
On Fri, Jan 23, 2015 at 10:11 PM Janis Voigtländer notifications@github.com
wrote:

After a good night's sleep, thought of these more descriptive function
names, hopefully making clear to the reader of this function what the role
of the Boolean value used there is.

@jwmerrill https://github.com/jwmerrill, what do you think of these

names?

You can view, comment on, or merge this pull request online at:

https://github.com/elm-lang/core/pull/136
Commit Summary

  • more descriptive local function names in fpsWhen

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/pull/136.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 24, 2015

Member

I like it too, thanks again!

Member

evancz commented Jan 24, 2015

I like it too, thanks again!

evancz pushed a commit that referenced this pull request Jan 24, 2015

Merge pull request #136 from jvoigtlaender/names
more descriptive local function names in fpsWhen

@evancz evancz merged commit 56072e4 into elm:master Jan 24, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:names branch Jan 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment