New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `console.error` for `stderr` port. #137

Merged
merged 1 commit into from Feb 16, 2015

Conversation

Projects
None yet
2 participants
@xtian
Contributor

xtian commented Jan 24, 2015

console.error logs an error message to the browser console. It's supported in all browsers back to IE8.

This code could actually be simplified to only use the console object since it's supported in node as well: http://nodejs.org/api/console.html

The only difference from writing directly to stdout/err is the addition of newlines to every message. I can amend this PR to make that change if that sounds alright.

@xtian

This comment has been minimized.

Show comment
Hide comment
@xtian

xtian Feb 16, 2015

Contributor

Can someone let me know if this is a desired change? Happy to close if not.

Contributor

xtian commented Feb 16, 2015

Can someone let me know if this is a desired change? Happy to close if not.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Feb 16, 2015

Member

Looks good to me. Thanks for pinging the PR and making this fix!

Member

evancz commented Feb 16, 2015

Looks good to me. Thanks for pinging the PR and making this fix!

evancz pushed a commit that referenced this pull request Feb 16, 2015

Merge pull request #137 from xtian/console-error
Use `console.error` for `stderr` port.

@evancz evancz merged commit abcb93e into elm:master Feb 16, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@xtian xtian deleted the xtian:console-error branch Feb 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment