Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upadded a missing `return` #138
Conversation
jvoigtlaender
referenced this pull request
Jan 24, 2015
Closed
Semantics of `fpsWhen` is quite off. #139
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Ahh, wow, thank you! |
pushed a commit
that referenced
this pull request
Jan 24, 2015
evancz
merged commit 5f61e93
into
elm:master
Jan 24, 2015
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
jvoigtlaender
deleted the
jvoigtlaender:missing-return
branch
Jan 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jvoigtlaender commentedJan 24, 2015
Without that
return, thelocalRuntime.setTimeoutin that line: https://github.com/elm-lang/core/blob/master/src/Native/Time.js#L50 doesn't give a meaningful return value, which means that theclearTimeoutin this line: https://github.com/elm-lang/core/blob/master/src/Native/Time.js#L58 has no effect whatsoever.This has led to buggy behavior of
fpsWhensince at least Elm-0.13 (checked with http://share-elm.com).