New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation of Signal.foldp #149

Merged
merged 1 commit into from Jan 29, 2015

Conversation

Projects
None yet
3 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Jan 29, 2015

@evancz evancz merged commit 6aabf51 into elm:master Jan 29, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:docu-signal-module branch Jan 29, 2015

@mietek

This comment has been minimized.

Show comment
Hide comment
@mietek

mietek Dec 31, 2015

What happened to this PR? I don’t see the commit in the history of src/Signal.

mietek commented Dec 31, 2015

What happened to this PR? I don’t see the commit in the history of src/Signal.

@jvoigtlaender jvoigtlaender restored the jvoigtlaender:docu-signal-module branch Dec 31, 2015

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Dec 31, 2015

Contributor

This is a very good question. @evancz, you merged this PR at some time, but nevertheless it, and its effect, are not visible. Did you mess with the git history at some point?

The change is still a useful one, I think. Should I simply make a new PR with the same content?

Contributor

jvoigtlaender commented Dec 31, 2015

This is a very good question. @evancz, you merged this PR at some time, but nevertheless it, and its effect, are not visible. Did you mess with the git history at some point?

The change is still a useful one, I think. Should I simply make a new PR with the same content?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment