New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Http requests for file:// scheme would not stall. #168

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mblsha

mblsha commented Feb 11, 2015

When XHR is finished for file:// resource, its status code is set to 0 both in cases of success and failure.

Guess this solution is better than stalling the XHR forever.

Make sure Http requests for file:// scheme would not stall.
When XHR is finished for file:// resource, its status code
is set to 0 both in cases of success and failure.

Guess this solution is better than stalling the XHR forever.
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Feb 22, 2015

Member

Thanks! We're currently working on a big rewrite of the Http library on the promises branch, so I think we shouldn't continue doing stuff to the old Http library. There are still some decisions to be made about whether the library or the user is in charge of dealing with these kinds of details, so this is good timing :) In any case, this information will be valuable over there.

Member

evancz commented Feb 22, 2015

Thanks! We're currently working on a big rewrite of the Http library on the promises branch, so I think we shouldn't continue doing stuff to the old Http library. There are still some decisions to be made about whether the library or the user is in charge of dealing with these kinds of details, so this is good timing :) In any case, this information will be valuable over there.

@evancz evancz closed this Feb 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment