/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Native `since` with a pure elm version. Fixes #9. #18

Merged
merged 2 commits into from Nov 24, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jwmerrill @evancz
@jwmerrill
Contributor

jwmerrill commented Nov 24, 2014

Motivation for this is that Signal.count went away. Taking this oportunity to
implement since in elm instead of in js.

jwmerrill added some commits Nov 24, 2014

@jwmerrill
Replace Native `since` with a pure elm version. Fixes #9. 
Motivation for this is that Signal.count went away. Taking this oportunity to
implement `since` in elm instead of in js.
c660305
@jwmerrill
Whitespace. Elm uses 4 space indents.
47602c4
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Nov 24, 2014

Member

Looks good to me, thanks!
Member

evancz commented Nov 24, 2014

Looks good to me, thanks!

evancz pushed a commit that referenced this pull request Nov 24, 2014

@process-bot
Merge pull request #18 from jwmerrill/pure-elm-since 
Replace Native `since` with a pure elm version. Fixes #9.
1d1131f

@evancz evancz merged commit 1d1131f into elm:master Nov 24, 2014

@jcollard jcollard referenced this pull request Nov 24, 2014

Closed

Added proposed implementation of Time.since. #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment