Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix a tiny typo in date module toTime function doc (1990 to 1970) #180
Conversation
audriussagadinas
added some commits
Feb 21, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
Feb 22, 2015
Member
Ah, thanks! Do you mind retargeting this change to the promises branch though? That's where all the latest work is happening.
|
Ah, thanks! Do you mind retargeting this change to the |
ThomasWeiser
referenced this pull request
Jun 13, 2015
Merged
Typo in Date.elm doc: Unix time starts 1970, not 1990. #275
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Go for #275 which also fixes this. Sorry for the big delay! |
evancz
closed this
Jun 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
audriussagadinas commentedFeb 21, 2015
Change 1990 to 1970 where 1990 was incorrect. Also specify that time is returned in milliseconds, because, by (common?) definition, UNIX time is number of SECONDS that have elapsed since midnight (UTC) of Thursday, 1 January 1970.
Remove extra empty line at file end.