/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime error in native toString #182

Closed
wants to merge 1 commit into
base: stable
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ThomasWeiser @kasbah
@ThomasWeiser
Contributor

ThomasWeiser commented Feb 24, 2015

toString needs special case for null value, otherwise it throws a type error.

To reproduce the bug: toString Json.Encode.null
TypeError: Cannot use 'in' operator to search for '' in null_
@ThomasWeiser
Fix runtime error in native toString 
toString needs special case for null value, otherwise it throws a type error.
d31ad43
@ThomasWeiser

This comment has been minimized.

Show comment
Hide comment
@ThomasWeiser

ThomasWeiser Feb 24, 2015

Contributor

I am unsure whether this bug-fix PR should go to stable branch or to master branch.
Contributor

ThomasWeiser commented Feb 24, 2015

I am unsure whether this bug-fix PR should go to stable branch or to master branch.
@kasbah

This comment has been minimized.

Show comment
Hide comment
@kasbah

kasbah Feb 24, 2015

Contributor

If it is merged into master I'll cherry pick it for next stable.
Contributor

kasbah commented Feb 24, 2015

If it is merged into master I'll cherry pick it for next stable.
@ThomasWeiser

This comment has been minimized.

Show comment
Hide comment
@ThomasWeiser

ThomasWeiser Feb 24, 2015

Contributor

Ok thanks. I have made a new PR (#183) against master branch.
Contributor

ThomasWeiser commented Feb 24, 2015

Ok thanks. I have made a new PR (#183) against master branch.

@ThomasWeiser ThomasWeiser closed this Feb 24, 2015

@ThomasWeiser ThomasWeiser referenced this pull request Mar 10, 2015

Closed

Fix runtime error in native toString (handling null values) #183

@ThomasWeiser ThomasWeiser deleted the ThomasWeiser:fix-toString-null branch Apr 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment