New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick for 1.1.2 release #192

Closed

kasbah wants to merge 3 commits into elm:stable from kasbah:stable

Contributor

kasbah commented Mar 10, 2015

As discussed previously here are my proposals for a stable release. Happy to add or delete anything of course.

brown-dragon and others added some commits Feb 13, 2015


      Fix bug in Array.map and Array.indexedMap

Array.map and Array.indexedMap have a bug that can most easily be seen
with the following use case:

EXPECTED: Array.empty == Array.map (\e -> e) Array.empty
ACTUAL: Array.empty != Array.map (\e -> e) Array.empty

(the same for Array.indexedMap)

This is because Array.map/Array.indexedMap initializes itself
incorrectly using:

        table: new Array(a.table)  // creates a new array with an array element

instead of

        table: new Array(a.table.length) // a correctly-sized array

This bug has been fixed in this commit

Conflicts:
	src/Native/Array.js

396d68f


      Prevent infinite loop from empty match (fix #77)

Conflicts:
	src/Native/Regex.js

fbb5ebc


      Add missing String->Char conversion (fix #73)

Conflicts:
	src/Native/Char.js
	tests/Test/Char.elm

77bab70

kasbah referenced this pull request Mar 10, 2015

Merged

Fixed bug in Array.map and Array.indexedMap #171

Contributor

kasbah commented Apr 21, 2015

Closing this due to release of 2.0.0.

kasbah closed this Apr 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.