Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix: Call Element.newElement as a native function #207
Conversation
xdissent
referenced this pull request
Apr 11, 2015
Merged
Use NativeElement.newElement in slider #91
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
It's fixed in the meantime |
ThomasWeiser
closed this
Apr 18, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Wait, so this got fixed since it was opened? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Yes, it got fixed with your commit 5b0bc59 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Cool, sorry for the confusion and thanks for the PR! |
ThomasWeiser
deleted the
ThomasWeiser:fix-newElement
branch
May 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ThomasWeiser commentedApr 4, 2015
newElement is now a native function in Native.Graphics.Element.js
It is not exported by Element.elm.
So calling it as Element.newElement throws a runtime error