New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing fpsWhen in a post-0.15 future #209

Closed
wants to merge 3 commits into
base: future
from

Conversation

Projects
None yet
2 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Apr 9, 2015

This is retargeting PR https://github.com/elm-lang/core/pull/198/ towards the future branch.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Apr 30, 2015

Contributor

Does this mean we are not going to have a future with a separate stream concept?

Contributor

jvoigtlaender commented Apr 30, 2015

Does this mean we are not going to have a future with a separate stream concept?

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Apr 30, 2015

Member

Oops, I cleaned out a bunch of branches that were zero commits in front of master not realizing that future was purposely behind. Do you happen to know which commit corresponds to the future branch so we can tag it?

Member

evancz commented Apr 30, 2015

Oops, I cleaned out a bunch of branches that were zero commits in front of master not realizing that future was purposely behind. Do you happen to know which commit corresponds to the future branch so we can tag it?

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Apr 30, 2015

Contributor

Oh. I'm not even sure I know how git is working, so "a commit corresponding to a branch"? Well, my best guessing would go like that: My branch in which I was working for this PR here, and which was diffed against the future branch to make this PR, currently ends with this commit. So maybe that is the one you are looking for. It seems that would make sense, because it happened one day before the current master branch has a commit titled "Get rid of Stream module, revert to 0.14 style Signals".

Contributor

jvoigtlaender commented Apr 30, 2015

Oh. I'm not even sure I know how git is working, so "a commit corresponding to a branch"? Well, my best guessing would go like that: My branch in which I was working for this PR here, and which was diffed against the future branch to make this PR, currently ends with this commit. So maybe that is the one you are looking for. It seems that would make sense, because it happened one day before the current master branch has a commit titled "Get rid of Stream module, revert to 0.14 style Signals".

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Apr 30, 2015

Contributor

Yes, this must be the commit you want. It has the exact same diff against my "fixing branch" as is shown in this PR here.

Contributor

jvoigtlaender commented Apr 30, 2015

Yes, this must be the commit you want. It has the exact same diff against my "fixing branch" as is shown in this PR here.

@Apanatshka Apanatshka referenced this pull request May 3, 2015

Closed

filterMap and filter #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment