/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Keyboard derived signals mergeable #229

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jvoigtlaender @evancz
@jvoigtlaender
Contributor

jvoigtlaender commented Apr 28, 2015

E.g., in Elm-0.14, merge Keyboard.arrows Keyboard.wasd made sence, but
it doesn't currently in Elm-0.15, because Keyboard.wasd will never be
propagated. The "culprit" was this commit, which profoundly changed the semantics of these signals by omitting a dropRepeats call that previously happened on the JS side.
@jvoigtlaender
make Keyboard derived signals mergeable 
e.g., in Elm-0.14, merge Keyboard.arrows Keyboard.wasd made sence, but
it doesn't currently in Elm-0.15, because Keyboard.wasd will *never* be
propagated
4bb494b
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Apr 29, 2015

Member

Okay, I merged this in. Not sure what's going on with github about it, but d5c1f49 should do it.

Thanks for figuring out the issue here! I'll do a patch release for this.
Member

evancz commented Apr 29, 2015

Okay, I merged this in. Not sure what's going on with github about it, but d5c1f49 should do it.

Thanks for figuring out the issue here! I'll do a patch release for this.

@evancz evancz closed this Apr 29, 2015

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:keysigs-mergeable branch Apr 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment