New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turned Path and Shape into separate types #235

Merged
merged 2 commits into from Jun 30, 2015

Conversation

Projects
None yet
3 participants
@jvoigtlaender
Contributor

jvoigtlaender commented May 1, 2015

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender May 21, 2015

Contributor

Merge this? You (@evancz) agreed in #234 that this separation should be enforced.

Contributor

jvoigtlaender commented May 21, 2015

Merge this? You (@evancz) agreed in #234 that this separation should be enforced.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender May 23, 2015

Contributor

Merged current master to make sure this still compiles.

Contributor

jvoigtlaender commented May 23, 2015

Merged current master to make sure this still compiles.

evancz pushed a commit that referenced this pull request Jun 30, 2015

Merge pull request #235 from jvoigtlaender/path-vs-shape
Turned Path and Shape into separate types

@evancz evancz merged commit 00ccb8a into elm:master Jun 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jun 30, 2015

Member

Thanks! This finally became a requirement with the new documentation tool.

Also, thanks for all the great PRs! The are always reasonable improvements with well-done PRs. Sometimes it takes me a while to realize it's the right thing though!

Member

evancz commented Jun 30, 2015

Thanks! This finally became a requirement with the new documentation tool.

Also, thanks for all the great PRs! The are always reasonable improvements with well-done PRs. Sometimes it takes me a while to realize it's the right thing though!

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:path-vs-shape branch Jun 30, 2015

@vilterp

This comment has been minimized.

Show comment
Hide comment
@vilterp

vilterp Aug 16, 2015

@evancz this change makes elm-diagrams not compile, so I would be in favor of the next core being a major version change

vilterp commented on ec5347d Aug 16, 2015

@evancz this change makes elm-diagrams not compile, so I would be in favor of the next core being a major version change

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 16, 2015

Member

Oh, it totally is a major change. If you try out elm-package diff it'll say why :)

Member

evancz replied Aug 16, 2015

Oh, it totally is a major change. If you try out elm-package diff it'll say why :)

@vilterp

This comment has been minimized.

Show comment
Hide comment
@vilterp

vilterp Aug 16, 2015

@evancz this change makes elm-diagrams not compile, so I would be in favor of the next core being a major version change

vilterp commented on ec5347d Aug 16, 2015

@evancz this change makes elm-diagrams not compile, so I would be in favor of the next core being a major version change

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 16, 2015

Member

Oh, it totally is a major change. If you try out elm-package diff it'll say why :)

Member

evancz replied Aug 16, 2015

Oh, it totally is a major change. If you try out elm-package diff it'll say why :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment