Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upTurned Path and Shape into separate types #235
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Merged current master to make sure this still compiles. |
pushed a commit
that referenced
this pull request
Jun 30, 2015
evancz
merged commit 00ccb8a
into
elm:master
Jun 30, 2015
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jun 30, 2015
Member
Thanks! This finally became a requirement with the new documentation tool.
Also, thanks for all the great PRs! The are always reasonable improvements with well-done PRs. Sometimes it takes me a while to realize it's the right thing though!
|
Thanks! This finally became a requirement with the new documentation tool. Also, thanks for all the great PRs! The are always reasonable improvements with well-done PRs. Sometimes it takes me a while to realize it's the right thing though! |
jvoigtlaender
deleted the
jvoigtlaender:path-vs-shape
branch
Jun 30, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
vilterp
Aug 16, 2015
@evancz this change makes elm-diagrams not compile, so I would be in favor of the next core being a major version change
vilterp
commented on ec5347d
Aug 16, 2015
|
@evancz this change makes elm-diagrams not compile, so I would be in favor of the next core being a major version change |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Aug 16, 2015
Member
Oh, it totally is a major change. If you try out elm-package diff it'll say why :)
|
Oh, it totally is a major change. If you try out |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
vilterp
Aug 16, 2015
@evancz this change makes elm-diagrams not compile, so I would be in favor of the next core being a major version change
vilterp
commented on ec5347d
Aug 16, 2015
|
@evancz this change makes elm-diagrams not compile, so I would be in favor of the next core being a major version change |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Aug 16, 2015
Member
Oh, it totally is a major change. If you try out elm-package diff it'll say why :)
|
Oh, it totally is a major change. If you try out |
jvoigtlaender commentedMay 1, 2015
addresses https://github.com/elm-lang/core/issues/234