Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded docu links between Char and Keyboard modules #237
Conversation
jvoigtlaender
and others
added some commits
May 2, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
jvoigtlaender
Aug 31, 2015
Contributor
Closing this, replaced by cleaner PRs https://github.com/elm-lang/core/pull/382 and https://github.com/elm-lang/core/pull/383 (that can be merged independently from each other).
|
Closing this, replaced by cleaner PRs https://github.com/elm-lang/core/pull/382 and https://github.com/elm-lang/core/pull/383 (that can be merged independently from each other). |
jvoigtlaender
closed this
Aug 31, 2015
jvoigtlaender
deleted the
jvoigtlaender:char-docu
branch
Aug 31, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jvoigtlaender commentedMay 2, 2015
Also, I wonder whether one of the two modules should import the other, so that the
KeyCodetype alias would be defined only in one place. (Imagine you change what type to use forKeyCodeat some point for some reason. If you forget about one of the two places, the types of some functions suddenly get out of sync (so that library users cannot really use them together), without the compiler being able to warn you as the implementer of the library.)