New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken error message #247

Merged
merged 1 commit into from May 15, 2015

Conversation

Projects
None yet
3 participants
@rehno-lindeque
Contributor

rehno-lindeque commented May 15, 2015

The runtime reports "arg is not defined" instead of the proper error message due to the value being propagated differently after the release of 0.15.

Fix broken error message
The runtime reports `"arg is not defined"` instead of the proper error due to the value being propagated differently after the release of 0.15.

evancz pushed a commit that referenced this pull request May 15, 2015

@evancz evancz merged commit 172023e into elm:master May 15, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 15, 2015

Member

Great, thank you!

Member

evancz commented May 15, 2015

Great, thank you!

@madsflensted

This comment has been minimized.

Show comment
Hide comment
@madsflensted

madsflensted Jun 10, 2015

Any chance this will be part of a patch release soon? Seems minor, but really blocks the helpful feedback from the port verification code, and turns a bad input type into a "say what?"-error.

madsflensted commented Jun 10, 2015

Any chance this will be part of a patch release soon? Seems minor, but really blocks the helpful feedback from the port verification code, and turns a bad input type into a "say what?"-error.

@rehno-lindeque

This comment has been minimized.

Show comment
Hide comment
@rehno-lindeque

rehno-lindeque Jun 10, 2015

Contributor

It's a great big hack, but can apply this locally to the core elm package if you want by the way (I did this because we needed it badly - it's only a two line fix). Would be nice to have bug fixes published in a rolling fashion though.

Contributor

rehno-lindeque commented Jun 10, 2015

It's a great big hack, but can apply this locally to the core elm package if you want by the way (I did this because we needed it badly - it's only a two line fix). Would be nice to have bug fixes published in a rolling fashion though.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jun 10, 2015

Member

It looks like I can do a MINOR release with a few rollbacks.

I think this is the second or third time that patches got held up on bigger changes, so I think it makes sense to start using the stable branch properly again. Any patch changes go directly there and get merged into master. We merge master into stable at more strategic times. Does that sound plausible?

If I get stable up to date with the latest public release, can someone cherry pick this over? Then we can do a PATCH no problem.

Member

evancz commented Jun 10, 2015

It looks like I can do a MINOR release with a few rollbacks.

I think this is the second or third time that patches got held up on bigger changes, so I think it makes sense to start using the stable branch properly again. Any patch changes go directly there and get merged into master. We merge master into stable at more strategic times. Does that sound plausible?

If I get stable up to date with the latest public release, can someone cherry pick this over? Then we can do a PATCH no problem.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jun 11, 2015

Member

Okay, 2.1.0 should be out with these changes.

Member

evancz commented Jun 11, 2015

Okay, 2.1.0 should be out with these changes.

@madsflensted

This comment has been minimized.

Show comment
Hide comment
@madsflensted

madsflensted commented Jun 11, 2015

👍

@rehno-lindeque

This comment has been minimized.

Show comment
Hide comment
@rehno-lindeque

rehno-lindeque Jun 12, 2015

Contributor

Thanks @evancz! I only rarely submit PR's but I'm happy to PR against a stable branch after being accepted into master from now on if that sounds like a good idea to you.

Contributor

rehno-lindeque commented Jun 12, 2015

Thanks @evancz! I only rarely submit PR's but I'm happy to PR against a stable branch after being accepted into master from now on if that sounds like a good idea to you.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jun 12, 2015

Member

No problem, that sounds good to me. And please let me know if I should do a patch release on things! By default I'll sync things up with the larger release cycle.

Member

evancz commented Jun 12, 2015

No problem, that sounds good to me. And please let me know if I should do a patch release on things! By default I'll sync things up with the larger release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment