Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix broken error message #247
Conversation
pushed a commit
that referenced
this pull request
May 15, 2015
evancz
merged commit 172023e
into
elm:master
May 15, 2015
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Great, thank you! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
madsflensted
Jun 10, 2015
Any chance this will be part of a patch release soon? Seems minor, but really blocks the helpful feedback from the port verification code, and turns a bad input type into a "say what?"-error.
madsflensted
commented
Jun 10, 2015
|
Any chance this will be part of a patch release soon? Seems minor, but really blocks the helpful feedback from the port verification code, and turns a bad input type into a "say what?"-error. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rehno-lindeque
Jun 10, 2015
Contributor
It's a great big hack, but can apply this locally to the core elm package if you want by the way (I did this because we needed it badly - it's only a two line fix). Would be nice to have bug fixes published in a rolling fashion though.
|
It's a great big hack, but can apply this locally to the core elm package if you want by the way (I did this because we needed it badly - it's only a two line fix). Would be nice to have bug fixes published in a rolling fashion though. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jun 10, 2015
Member
It looks like I can do a MINOR release with a few rollbacks.
I think this is the second or third time that patches got held up on bigger changes, so I think it makes sense to start using the stable branch properly again. Any patch changes go directly there and get merged into master. We merge master into stable at more strategic times. Does that sound plausible?
If I get stable up to date with the latest public release, can someone cherry pick this over? Then we can do a PATCH no problem.
|
It looks like I can do a MINOR release with a few rollbacks. I think this is the second or third time that patches got held up on bigger changes, so I think it makes sense to start using the If I get stable up to date with the latest public release, can someone cherry pick this over? Then we can do a PATCH no problem. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Okay, 2.1.0 should be out with these changes. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
madsflensted
commented
Jun 11, 2015
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rehno-lindeque
Jun 12, 2015
Contributor
Thanks @evancz! I only rarely submit PR's but I'm happy to PR against a stable branch after being accepted into master from now on if that sounds like a good idea to you.
|
Thanks @evancz! I only rarely submit PR's but I'm happy to PR against a stable branch after being accepted into master from now on if that sounds like a good idea to you. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jun 12, 2015
Member
No problem, that sounds good to me. And please let me know if I should do a patch release on things! By default I'll sync things up with the larger release cycle.
|
No problem, that sounds good to me. And please let me know if I should do a patch release on things! By default I'll sync things up with the larger release cycle. |
rehno-lindeque commentedMay 15, 2015
The runtime reports
"arg is not defined"instead of the proper error message due to the value being propagated differently after the release of 0.15.