/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Dict code #254

Closed
wants to merge 5 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jvoigtlaender
@jvoigtlaender
Contributor

jvoigtlaender commented May 27, 2015

  • removing redundant bindings
  • inlining/simplifying case branches
  • removing two unused, and unexported, functions

jvoigtlaender added some commits May 27, 2015

@jvoigtlaender
remove unused, and unexported, function
ac8237f
@jvoigtlaender
remove redundant bindings 
Note that `l` and `r` already have exactly those values due to the
pattern match of which this is a branch.
295b9a4
@jvoigtlaender
inline a trivial case 
Note that `l` at that point is `RBNode cl kl vl ll rl`, of which `max`
is simply `(kl, vl)` by the definition.
781787a
@jvoigtlaender
remove another now unused, and unexported, function
5e86749
@jvoigtlaender
simplify case branch
3074b00
@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender May 27, 2015

Contributor

Ah, sorry, the last of these simplification steps were too quick. So I'll revise.

The test suite / Travis went green, though. So test coverage of Dict does not seem to be very deep.
Contributor

jvoigtlaender commented May 27, 2015

Ah, sorry, the last of these simplification steps were too quick. So I'll revise.

The test suite / Travis went green, though. So test coverage of Dict does not seem to be very deep.

@jvoigtlaender jvoigtlaender closed this May 27, 2015

@jvoigtlaender jvoigtlaender referenced this pull request May 27, 2015

Closed

Simplify Dict code, and eliminate calls to Debug.crash #255

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:dict branch May 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment