New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infix operator for exponentiation should be right-associative #256

Merged
merged 1 commit into from May 29, 2015

Conversation

Projects
None yet
3 participants
@ThomasWeiser
Contributor

ThomasWeiser commented May 28, 2015

I don't think that anyone will ever use an expression like 3^3^3,
but it's nicer to follow the general convention.
Otherwise it would look like an oversight.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 28, 2015

Member

I saw you mentioned that this is the standard in other languages. Do you mind sharing a few links as evidence just for the record? Otherwise this looks great to me, thank you for finding this and sending a PR!

Member

evancz commented May 28, 2015

I saw you mentioned that this is the standard in other languages. Do you mind sharing a few links as evidence just for the record? Otherwise this looks great to me, thank you for finding this and sending a PR!

@ThomasWeiser

This comment has been minimized.

Show comment
Hide comment
@ThomasWeiser

ThomasWeiser May 28, 2015

Contributor

Haskell:

F# operator **

Python operator **

R: The exponentiation operator ^ [...] group right to left

And a proposal for Javascript/ES7

Contributor

ThomasWeiser commented May 28, 2015

Haskell:

F# operator **

Python operator **

R: The exponentiation operator ^ [...] group right to left

And a proposal for Javascript/ES7

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 29, 2015

Member

Great, thank you!

Member

evancz commented May 29, 2015

Great, thank you!

evancz pushed a commit that referenced this pull request May 29, 2015

Merge pull request #256 from ThomasWeiser/fix-exponentiation-assoc
Infix operator for exponentiation should be right-associative

@evancz evancz merged commit ad00476 into elm:master May 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold May 30, 2015

Contributor

I doubt anyone is relying on this, but isn't it a backwards-incompatible change?

Contributor

mgold commented May 30, 2015

I doubt anyone is relying on this, but isn't it a backwards-incompatible change?

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 31, 2015

Member

Yes, it is. I have an item on my todo list of "fixity changes are breaking changes in elm-package" but it is not implemented right now. Not sure what I'm going to do. It may be that the explicit exports that @jvoigtlaender added recently will "remove" some functions causing a major version change anyway.

Member

evancz commented May 31, 2015

Yes, it is. I have an item on my todo list of "fixity changes are breaking changes in elm-package" but it is not implemented right now. Not sure what I'm going to do. It may be that the explicit exports that @jvoigtlaender added recently will "remove" some functions causing a major version change anyway.

@ThomasWeiser ThomasWeiser deleted the ThomasWeiser:fix-exponentiation-assoc branch Jul 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment