Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSmall code improvement in Dict.elm #261
Conversation
pushed a commit
that referenced
this pull request
Jun 5, 2015
evancz
merged commit 744a514
into
elm:master
Jun 5, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Makes sense to me! |
jvoigtlaender
deleted the
jvoigtlaender:patch-1
branch
Jun 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jvoigtlaender commentedJun 4, 2015
I guess this makes it more obvious what that code is doing, and is also more in line with how other non-auxiliary functions in this module are written.
Of course, semantically there is no change, due to this definition: https://github.com/elm-lang/core/blob/2.0.1/src/Dict.elm#L82