New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed sentence in `Dict.elm` documentation #262

Merged
merged 1 commit into from Jun 4, 2015

Conversation

Projects
None yet
2 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Jun 4, 2015

The sentence made no sense. The resulting dictionary will only contain the keys that appear in the first but not in the second given dictionary. So of course, the values for those keys can only come from the first dictionary. There is no potential conflict between values, since if a key occurs in both given dictionaries, it will be dropped anyway, so there is no need to decide "by some preference" which value (from first or from second dictionary) to choose.

I found the sentence quite confusing.

removed sentence in Dict.elm documentation
The sentence made no sense. The resulting dictionary will only contain the keys that appear in the first but not in the second given dictionary. So of course, the values for those keys can only come from the first dictionary. There is no potential conflict between values, since if a key occurs in both given dictionaries, it will be dropped anyway, so there is no need to decide "by some preference" which value (from first or from second dictionary) to choose.

evancz pushed a commit that referenced this pull request Jun 4, 2015

Merge pull request #262 from jvoigtlaender/patch-2
Removed sentence in `Dict.elm` documentation

@evancz evancz merged commit 594c7a4 into elm:master Jun 4, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:patch-2 branch Jun 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment