New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `Set t` a type different from `Dict t ()` #263

Merged
merged 1 commit into from Jun 29, 2015

Conversation

Projects
None yet
3 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Jun 5, 2015

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Jun 8, 2015

Contributor

This will force core to version 3.0.0. I'm not sure we're there yet. Semvar aside, looks good.

Incidental: maybe we need a breaking branch so we could merge this now and forget about it until the next major release?

Contributor

mgold commented Jun 8, 2015

This will force core to version 3.0.0. I'm not sure we're there yet. Semvar aside, looks good.

Incidental: maybe we need a breaking branch so we could merge this now and forget about it until the next major release?

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jun 25, 2015

Contributor

This here is, of course, another case like the ones in #283.

Contributor

jvoigtlaender commented Jun 25, 2015

This here is, of course, another case like the ones in #283.

evancz pushed a commit that referenced this pull request Jun 29, 2015

Merge pull request #263 from jvoigtlaender/dict-vs-set
Make `Set t` a type different from `Dict t ()`

@evancz evancz merged commit e9c920d into elm:master Jun 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jun 29, 2015

Member

With the new docs format, I think we need to fix all of these cases. Thanks for the PR!

Member

evancz commented Jun 29, 2015

With the new docs format, I think we need to fix all of these cases. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment