New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct behavior of `toString` #267

Merged
merged 1 commit into from Jun 8, 2015

Conversation

Projects
None yet
2 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Jun 6, 2015

... on signals, should say "", not "".

Much as I regret that we don't have separate signal and stream concepts: As long as we don't, messages to the programmer/user should name the concept correctly. Currently, if you run

import Graphics.Element

main = Graphics.Element.show (Signal.constant 42)

you get output "". But it should be (and before 0.15, was): "". Streams are not a thing, currently.

correct behavior of `toString`
... on signals, should say '<Signal>', not '<Stream>'

evancz pushed a commit that referenced this pull request Jun 8, 2015

Merge pull request #267 from jvoigtlaender/patch-2
Correct behavior of `toString`

@evancz evancz merged commit 34f5833 into elm:master Jun 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jun 8, 2015

Member

Thank you for the fix!

Member

evancz commented Jun 8, 2015

Thank you for the fix!

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:patch-2 branch Jun 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment