/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to support new debugger API #306

Closed
wants to merge 6 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vilterp @evancz
@vilterp

vilterp commented Jul 22, 2015

  • Time signals notify Utils.Tuple0 instead of null
  • output nodes save their value (so the debugger can get their values w/out having to look at their parents)
  • saving whether a node was really updated each frame

Will let you know when this is ready for review.
Show outdated Hide outdated src/Native/Runtime.js
var container = document.createElement('div');
document.body.appendChild(container);
if(connected) {
document.body.appendChild(container);

This comment has been minimized.

Show comment
Hide comment
@vilterp

vilterp Jul 28, 2015

TODO: think of a solution better than simply leaving this tree unconnected to the document. As is, there are 2 identical DOM trees (this one and the one owned by the debugger), so we incur DOM mutation costs twice.
Copy URL
@vilterp

vilterp Jul 28, 2015

TODO: think of a solution better than simply leaving this tree unconnected to the document. As is, there are 2 identical DOM trees (this one and the one owned by the debugger), so we incur DOM mutation costs twice.

@vilterp vilterp referenced this pull request Aug 6, 2015

Closed

Rebuild debugger on new Task-based runtime api #135

7 of 20 tasks complete

vilterp added some commits Jul 22, 2015

@vilterp
changes to support new debugger API 
- Time singals notify Utils.Tuple0 instead of null
- Elm.fullscreen has an option which will make it not actually attach
  its node to the DOM (because the debugger owns the screen)
- output nodes save their value (so the debugger can get them, instead
  of having to look at their parents)
0489139
@vilterp
initialize output with parent's value
e85d520
@vilterp
make log work w/ reactor, fix bug in Element.js; Keyboard blur returns 
() instead of null
9e79d17
@vilterp
attach debuggee to document w/ visibility=hidden instead of not 
attaching it

so that the Window module can get the width of the node
ff30362
@vilterp
don't have a disconnected mode in Elm.fullscreen anymore 
(since we're back to debuggee running normally -- owning the screen
itself)
802851d
@vilterp
add `updatedThisFrame` attribute to nodes 
true when `parentUpdate` argument to notify is true, false otherwise
9bb6138
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Apr 28, 2016

Member

Doesn't match with things anymore
Member

evancz commented Apr 28, 2016

Doesn't match with things anymore

@evancz evancz closed this Apr 28, 2016

@vilterp

This comment has been minimized.

Show comment
Hide comment
@vilterp

vilterp Apr 28, 2016

😢 alas, it does not. I'll take another look at 0.17 core to think about how to make this work…

vilterp commented Apr 28, 2016

😢 alas, it does not. I'll take another look at 0.17 core to think about how to make this work…
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Apr 28, 2016

Member

I don't think it'll need any changes here anymore. Take a look at elm-reactor. I cleaned up a bunch of stuff, but ultimately had to turn certain features off to get it releasable. The issues now are not "how can I hack the code?" They are things like "What does it mean to rewind when an effect manager cannot follow suit?" So it requires some thinking about the fundamental capabilities we will be able to provide and how to make that happen.
Member

evancz commented Apr 28, 2016

I don't think it'll need any changes here anymore. Take a look at elm-reactor. I cleaned up a bunch of stuff, but ultimately had to turn certain features off to get it releasable. The issues now are not "how can I hack the code?" They are things like "What does it mean to rewind when an effect manager cannot follow suit?" So it requires some thinking about the fundamental capabilities we will be able to provide and how to make that happen.
@vilterp

This comment has been minimized.

Show comment
Hide comment
@vilterp

vilterp Apr 28, 2016

K, will take a look.

vilterp commented Apr 28, 2016

K, will take a look.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment