New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for Signal.forwardTo #315

Merged
merged 1 commit into from Aug 2, 2015

Conversation

Projects
None yet
2 participants
@mgold
Contributor

mgold commented Jul 30, 2015

Because a new version of core may be coming out soon, this is a hopefully very simple and uncontroversial change to the docs for Signal.forwardTo. We remove the port keyword, which is wrong and misleading. Then, we define the actions mailbox in a reasonable way rather than just saying that is exists.

evancz pushed a commit that referenced this pull request Aug 2, 2015

Merge pull request #315 from mgold/forwardTo-docs
Improve docs for Signal.forwardTo

@evancz evancz merged commit 34c8854 into elm:master Aug 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 2, 2015

Member

Nice, thank you for fixing this! It's a shame the type checker doesn't know about comments :P

Member

evancz commented Aug 2, 2015

Nice, thank you for fixing this! It's a shame the type checker doesn't know about comments :P

@mgold mgold referenced this pull request Aug 3, 2015

Closed

Revise docs for Mailboxes #259

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Aug 3, 2015

Contributor

Thanks for merging. Although, port actions : Mailbox Action is a valid incoming port declaration, so maybe even automated compilation of docs examples would have missed it!

Contributor

mgold commented Aug 3, 2015

Thanks for merging. Although, port actions : Mailbox Action is a valid incoming port declaration, so maybe even automated compilation of docs examples would have missed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment