Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove docs for Signal.forwardTo #315
Conversation
pushed a commit
that referenced
this pull request
Aug 2, 2015
evancz
merged commit 34c8854
into
elm:master
Aug 2, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
Aug 2, 2015
Member
Nice, thank you for fixing this! It's a shame the type checker doesn't know about comments :P
|
Nice, thank you for fixing this! It's a shame the type checker doesn't know about comments :P |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
mgold
Aug 3, 2015
Contributor
Thanks for merging. Although, port actions : Mailbox Action is a valid incoming port declaration, so maybe even automated compilation of docs examples would have missed it!
|
Thanks for merging. Although, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mgold commentedJul 30, 2015
Because a new version of core may be coming out soon, this is a hopefully very simple and uncontroversial change to the docs for
Signal.forwardTo. We remove theportkeyword, which is wrong and misleading. Then, we define theactionsmailbox in a reasonable way rather than just saying that is exists.