New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change description of List.member #316

Merged
merged 1 commit into from Aug 2, 2015

Conversation

Projects
None yet
3 participants
@jessitron

jessitron commented Jul 30, 2015

because this function is called 'contains' in many languages, I hit
this documentation, searched for 'contains,' and didn't find the right
method. Putting 'contains' in the description for 'member' help with this

Jessica Kerr
Change description of List.member
because this function is called 'contains' in many languages, I hit
this documentation, searched for 'contains,' and didn't find the right
method. Putting 'contains' in the description for 'member' help with this

evancz pushed a commit that referenced this pull request Aug 2, 2015

Merge pull request #316 from jessitron/master
Change description of List.member

@evancz evancz merged commit d2146c1 into elm:master Aug 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 2, 2015

Member

Great idea!

I'd be curious to know the list of languages that use that naming convention (and which languages do other things). Perhaps the best move is to rename this to contains in Set and List and Array and such. If you are interested, it would be cool to have a PR in the style of #317 outlining which languages use what and potentially get that added to #322.

Anyway, thanks for the fix!

Member

evancz commented Aug 2, 2015

Great idea!

I'd be curious to know the list of languages that use that naming convention (and which languages do other things). Perhaps the best move is to rename this to contains in Set and List and Array and such. If you are interested, it would be cool to have a PR in the style of #317 outlining which languages use what and potentially get that added to #322.

Anyway, thanks for the fix!

@Mouvedia

This comment has been minimized.

Show comment
Hide comment
@Mouvedia

Mouvedia Dec 24, 2016

I wanted to do something similar for Array. JS has Array.prototype.includes so I wanted to use include. The problem is, there's no member method listed there.

@evancz why is that?

Mouvedia commented Dec 24, 2016

I wanted to do something similar for Array. JS has Array.prototype.includes so I wanted to use include. The problem is, there's no member method listed there.

@evancz why is that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment