/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of window object in Date and Time native modules. #320

Merged
merged 1 commit into from Aug 2, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ajhager @evancz
@ajhager
Contributor

ajhager commented Aug 1, 2015

Fixes elm-lang/elm-repl#70 by changing a few instances of new window.Date to new Date.

@ajhager ajhager referenced this pull request Aug 1, 2015

Closed

Add support for running and importing compiled elm programs from node #318

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 2, 2015

Member

Great, thank you!

In past versions of native modules, I think there was some clash between our Date and JavaScript's Date but I guess that is resolved now.
Member

evancz commented Aug 2, 2015

Great, thank you!

In past versions of native modules, I think there was some clash between our Date and JavaScript's Date but I guess that is resolved now.

evancz pushed a commit that referenced this pull request Aug 2, 2015

@process-bot
Merge pull request #320 from ElmCast/data-time 
Remove use of window object in Date and Time native modules.
c309005

@evancz evancz merged commit c309005 into elm:master Aug 2, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment