New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how Sets and Dicts are shown #323

Merged
merged 2 commits into from Aug 3, 2015

Conversation

Projects
None yet
2 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Aug 2, 2015

Addresses the Set-related part of https://github.com/elm-lang/core/issues/288.

Before this PR, using toString/show on the following three expressions:

  • Set.fromList [1,2,3]
  • Dict.fromList [(1,()),(2,()),(3,())]
  • Dict.fromList [(1,1),(2,2),(3,3)]

would lead to:

  • "Set (Set.fromList [1,2,3])"
  • "Set.fromList [1,2,3]"
  • "Dict.fromList [(1,1),(2,2),(3,3)]"

After this PR, the resulting strings are:

  • "Set.fromList [1,2,3]"
  • "Dict.fromList [(1,()),(2,()),(3,())]"
  • "Dict.fromList [(1,1),(2,2),(3,3)]"

evancz pushed a commit that referenced this pull request Aug 3, 2015

Merge pull request #323 from jvoigtlaender/show-Sets
Fix how Sets and Dicts are shown

@evancz evancz merged commit bf4c0e8 into elm:master Aug 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 3, 2015

Member

Alright, looks good to me, thank you!

Member

evancz commented Aug 3, 2015

Alright, looks good to me, thank you!

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:show-Sets branch Aug 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment