Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix how Sets and Dicts are shown #323
Conversation
jvoigtlaender
added some commits
Aug 2, 2015
jvoigtlaender
referenced this pull request
Aug 2, 2015
Closed
Behavior of toString relying on special constructor names #288
pushed a commit
that referenced
this pull request
Aug 3, 2015
evancz
merged commit bf4c0e8
into
elm:master
Aug 3, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Alright, looks good to me, thank you! |
jvoigtlaender
deleted the
jvoigtlaender:show-Sets
branch
Aug 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jvoigtlaender commentedAug 2, 2015
Addresses the
Set-related part of https://github.com/elm-lang/core/issues/288.Before this PR, using
toString/showon the following three expressions:Set.fromList [1,2,3]Dict.fromList [(1,()),(2,()),(3,())]Dict.fromList [(1,1),(2,2),(3,3)]would lead to:
"Set (Set.fromList [1,2,3])""Set.fromList [1,2,3]""Dict.fromList [(1,1),(2,2),(3,3)]"After this PR, the resulting strings are:
"Set.fromList [1,2,3]""Dict.fromList [(1,()),(2,()),(3,())]""Dict.fromList [(1,1),(2,2),(3,3)]"