Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't create div container in fullscreen mode #331
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Aug 4, 2015
Member
To what extent have you tested that things like Window.dimensions work with this change? I suspect it's not as simple as this, but I don't recall exactly the reasons for that div.
|
To what extent have you tested that things like |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
suryagaddipati
Aug 5, 2015
Ah, I guessed there was a reason for it but not sure why it was there.
It was messing up my css, I ended up fixing my css. But the extra div is certainly unexpected.
I will try to test it with Window.dimesions
suryagaddipati
commented
Aug 5, 2015
|
Ah, I guessed there was a reason for it but not sure why it was there. I will try to test it with |
suryagaddipati
closed this
Aug 5, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Aug 5, 2015
Member
Okay :) I'd check out the signals in Mouse as well. I don't recall the exact reason it ended up like this, and perhaps it's a reason that is no longer true.
Anyway, please reopen once you have more data!
|
Okay :) I'd check out the signals in Anyway, please reopen once you have more data! |
suryagaddipati commentedAug 4, 2015
No description provided.