New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotation of shape forms #338

Merged
merged 1 commit into from Aug 6, 2015

Conversation

Projects
None yet
4 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Aug 6, 2015

Fixes https://github.com/elm-lang/core/issues/335.

Previously, something like

main : Signal Element
main = map (\t -> collage 500 500 [rotate (degrees t) (filled black (square 400))]) (every 20)

did not work since the t got to large for how rotation of Shape-Forms (as opposed to Element-Forms) is implemented.

evancz pushed a commit that referenced this pull request Aug 6, 2015

@evancz evancz merged commit 912bf95 into elm:master Aug 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 6, 2015

Member

Awesome, thank you!

Member

evancz commented Aug 6, 2015

Awesome, thank you!

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:rotate-shapes branch Aug 6, 2015

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Aug 6, 2015

Contributor

Thanks Janis. Should I be worried about the cost of modulus every frame?

Contributor

mgold commented Aug 6, 2015

Thanks Janis. Should I be worried about the cost of modulus every frame?

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 6, 2015

Member

I was thinking it may make sense to define twoPi or something, but I suspect the mod is fine.

Member

evancz commented Aug 6, 2015

I was thinking it may make sense to define twoPi or something, but I suspect the mod is fine.

@TheSeamau5

This comment has been minimized.

Show comment
Hide comment
@TheSeamau5

TheSeamau5 Aug 6, 2015

Contributor

You mean, tau? http://tauday.com/

Contributor

TheSeamau5 commented Aug 6, 2015

You mean, tau? http://tauday.com/

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Aug 7, 2015

Contributor

+1 for tau!

Contributor

mgold commented Aug 7, 2015

+1 for tau!

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 7, 2015

Member

@mgold, can you do a PR? I also know about tau, but I'd still like to call it twoPi because more people will know what it means.

Member

evancz commented Aug 7, 2015

@mgold, can you do a PR? I also know about tau, but I'd still like to call it twoPi because more people will know what it means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment