Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix rotation of shape forms #338
Conversation
pushed a commit
that referenced
this pull request
Aug 6, 2015
evancz
merged commit 912bf95
into
elm:master
Aug 6, 2015
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Awesome, thank you! |
jvoigtlaender
deleted the
jvoigtlaender:rotate-shapes
branch
Aug 6, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mgold
Aug 6, 2015
Contributor
Thanks Janis. Should I be worried about the cost of modulus every frame?
|
Thanks Janis. Should I be worried about the cost of modulus every frame? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Aug 6, 2015
Member
I was thinking it may make sense to define twoPi or something, but I suspect the mod is fine.
|
I was thinking it may make sense to define |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
You mean, |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
+1 for tau! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Aug 7, 2015
Member
@mgold, can you do a PR? I also know about tau, but I'd still like to call it twoPi because more people will know what it means.
|
@mgold, can you do a PR? I also know about tau, but I'd still like to call it |
jvoigtlaender commentedAug 6, 2015
Fixes https://github.com/elm-lang/core/issues/335.
Previously, something like
did not work since the
tgot to large for how rotation ofShape-Forms (as opposed toElement-Forms) is implemented.