Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Tests for Elm 0.14, elm-package, elm-make, etc. #34
Conversation
maxsnew
added some commits
Dec 8, 2014
pushed a commit
that referenced
this pull request
Dec 8, 2014
evancz
merged commit 1cb38bb
into
elm:master
Dec 8, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
maxsnew commentedDec 8, 2014
Currently a test is failing in the Array test file, but the error reported is a pattern match failure in Dict.elm, so it could be either a Dict bug or the Native Array code is producing an invalid object somewhere.
See the .travis.yml file for how it works, but the most important line to note is https://github.com/maxsnew/core/compare/elm-lang:master...maxsnew:tests?expand=1#diff-354f30a63fb0907d4ad57269548329e3R21 , where I filter out calls to
appendChildbecause they mask any actual errors that the program has. It would be preferable if these never happened in the first place.